search

Khan / react-components

khan.github.io/react-components/
MIT License
1.01k stars 99 forks source link

timeout transition group TICK doesn't trigger animation in Safari? #40

Closed noahgrant closed 9 years ago

noahgrant commented 9 years ago

Hi,

Have you noticed that the TICK of 17 ms in timeout transition group doesn't seem to be enough to trigger an animation in Safari (desktop or mobile)? Seems to work great in everything else.

Thanks!

Noah

idw111 commented 9 years ago

I'm experiencing the same issue. Safari does not seem to work properly with TimeoutTransitionGroup.

devgeeks commented 9 years ago

:+1:

I also appear to be seeing this... not sure if it has always been true or only recently.

devgeeks commented 9 years ago

Found this issue on ReactCSSTransitionGroup

https://github.com/facebook/react/issues/2104

I tried it, and moving the transition CSS from enter to enter-active fixes this issue on Safari.

noahgrant commented 9 years ago

wow, that worked for me, too. i should add that i also had to remove the transition from enter, not just add it to enter-active (i had tried adding it to both, which didn't work). i'll close this, though it'd be nice if the interface mirrored CSSTransitionGroup (minus the timeouts, of course).

sophiebits commented 9 years ago

@noahgrant Sorry, what would you like changed here?