search

Khan / react-components

khan.github.io/react-components/
MIT License
1.01k stars 99 forks source link

Removes petulant verbiage #47

Closed austinpray closed 9 years ago

austinpray commented 9 years ago

👮

joelburget commented 9 years ago

I think I'd rather remove / rephrase this sentence. (As the original author) it comes off as petulant.

austinpray commented 9 years ago

Delete

You should know that I highly recommend not using this mixin. It inevitably leads to inefficient code and janky UX. Not at first - only gradually. You won't really notice until it's too late and BackboneMixin runs the interface you just spent three months on.

Anyway, you're your own person - do what you think is right.

Replace with

This mixin is deprecated. We do not recommend using it in production.

?

joelburget commented 9 years ago

Looks perfect to me!

On Sep 11, 2015, at 4:35 PM, Austin Pray notifications@github.com wrote:

Delete

You should know that I highly recommend not using this mixin. It inevitably leads to inefficient code and janky UX. Not at first - only gradually. You won't really notice until it's too late and BackboneMixin runs the interface you just spent three months on.

Anyway, you're your own person - do what you think is right.

Replace with

This mixin is deprecated and we do not recommend using it in production.

?

— Reply to this email directly or view it on GitHub https://github.com/Khan/react-components/pull/47#issuecomment-139655757.

austinpray commented 9 years ago

@joelburget amended the commit to reflect the changes

itsjohncs commented 9 years ago

Whoops, sorry this never got merged!