search

Khan / react-components

khan.github.io/react-components/
MIT License
1.01k stars 99 forks source link

Implementing "appear" in timeout transition group #49

Closed johnmanong closed 8 years ago

johnmanong commented 8 years ago

Hey guys,

Have you thought about adding the transitionAppear functionality to timeout-transition-group.jsx? Happy to send a PR if your interested.

sophiebits commented 8 years ago

As of React 0.14 you can (and should) specify timeouts directly on CSSTransitionGroup so TimeoutTransitionGroup isn't needed.

johnmanong commented 8 years ago

Is that component considered deprecated then?

In our case, we aren't ready to update to 14 and are using timeout groups.

On Friday, November 13, 2015, Ben Alpert notifications@github.com wrote:

Closed #49 https://github.com/Khan/react-components/issues/49.

— Reply to this email directly or view it on GitHub https://github.com/Khan/react-components/issues/49#event-464261747.

Best, John Ong

johnmanong commented 8 years ago

@spicyj ?

ariabuckles commented 8 years ago

@johnmanong yes, I'd consider this component deprecated. If you want to add transitionAppear to a fork and use that because you're on on React 0.14 yet, go for it! But that probably won't be merged upstream <3.

johnmanong commented 8 years ago

Sounds good! Thanks for the update!!

On Monday, November 16, 2015, Aria Buckles notifications@github.com wrote:

@johnmanong https://github.com/johnmanong yes, I'd consider this component deprecated. If you want to add transitionAppear to a fork and use that because you're on on React 0.14 yet, go for it! But that probably won't be merged upstream <3.

— Reply to this email directly or view it on GitHub https://github.com/Khan/react-components/issues/49#issuecomment-157149144 .

Best, John Ong