search

Khan / structured-blocks

MIT License
11 stars 2 forks source link

Generated comment blocks are associated with the wrong line #68

Closed jbrennan closed 9 years ago

jbrennan commented 9 years ago

Comment blocks generated from JS get inserted below the block, but they’re supposed to be above it.

See in this screenshot, it’s actually the first ellipse that makes the face:

screen shot 2014-11-25 at 9 51 20 am

jeresig commented 9 years ago

Actually, if you look at the original JS that's actually correct -- the comments are actually after the statement: https://www.khanacademy.org/computing/computer-programming/programming/drawing-basics/p/challenge-crazy-face

This is actually a case where the comments should probably be moved above the statement (I think we typically put comments on a new line). I'll defer the handling of this to @pamelafox.