search

KhanovaSkola / khanovaskola-v3

https://khanovaskola.cz
MIT License
2 stars 3 forks source link

Video editor broken #18

Closed danielhollas closed 4 years ago

danielhollas commented 4 years ago

Adding new video fails with a message from DB about NULL value for created_at column

danielhollas commented 4 years ago

Looks like it got broken here: https://github.com/KhanovaSkola/khanovaskola-v3/commit/cb8e1285914032733a293e925d5461e8e8e0209e#diff-60f96a70213f4945301b85a8579c57a9

I guess created_at cannot be indexable? Reverting that part of that commit should fix it (need to remove "created_at" from the video template. I think it's not mandatory by Google for SEO but need to check first.

danielhollas commented 4 years ago

Fork, the uploadDate field is required by Google. :frowning:

https://developers.google.com/search/docs/data-types/video#enhance

We either need to fix fudge it or fix it properly. Sigh.

danielhollas commented 4 years ago

Managed to fix it properly. :tada: Fortunately, it was a one-line fix. :relieved: