pawaitemadisoncollege
commented
3 years ago All right @Kharsla! Glad to see you implemented hibernate in your indie project already!
- [ ] Is the setup method with the cleandb.sql working? I noticed an exception that looks like it happened with the Database class:
- [ ] Is the coverage percentage in the screenshot showing for the Dao or another class? It should show 100% coverage for the Dao (and for the entire persistence package).
- [ ] Verifying the entities are saved/updated/inserted correctly can be more thorough by implementing and using equals() on each entity - refer to the video Comparing Hibernate Entities with equals in week 5 for more detail. An example of using that equals method in a unit test would be something like
assertTrue(expectedUser.equals(actualUser));so that you don't have to compare each instance var/column manually like this: https://github.com/Kharsla/GroceryListGenerator/blob/96e5af269256674a66d020d8ba3f080663c4b4f9/src/test/finalproject/persistence/RecipeDaoTest.java#L37-L38
@pawaitemadisoncollege Week 4 is complete. Learning more about the dao and hibernate was good this week. I struggled with the user tests as my tests caused the recipeId to change and as some of my testes were id dependent it messed with my tests.