Kherae / FU-Avali-Triage-Patch

Patch to address issues between avali triage and FU
2 stars 3 forks source link

I'd like permission to merge this with the main mod #3

Open Fevix opened 2 years ago

Fevix commented 2 years ago

Unless, of course, there are parts of it that depend on Frackin Universe, in which case those parts should remain as part of this compat patch.

Kherae commented 2 years ago

you can merge, just make sure you do it correctly.

what shouldn't be merged: /items/food because that's where the dummy item for detection is. /items/generic/produce, treasure, recipes, npc folders: because FU uses actual names instead of 'avalifruit<1-3>' or 'avaliplant<1-3>' species folder, as avali dont innately have FR/FU

can be merged (you will need to copy the parameter changes into the files that are patched): /items/generic/crafting /items/active /items/materials /objects

Fevix commented 2 years ago

I know it took me a while but I just started and immediately noticed a few issues:

Avali melee weapons are not in \items\active\tiered, they're in \items\active\weapons\melee\tiered, so your patch files are patching nothing. Additionally, avali melee weapons already have their respective category entry.

Kherae commented 2 years ago

removing those, then. also, it's funny because I'm the one who added those categories to the weapons...oops