search

Khhs167 / memstack

A basic linked-list based tool for managing memory
MIT License
4 stars 2 forks source link

Fix TRUE/FALSE macro colission via prefixing them. #13

Closed Khhs167 closed 1 year ago

Khhs167 commented 1 year ago

As mentioned in #6, the boolean macros might interfere with user-defined macros, and thus I believe they should be renamed.

My solution would be to rename them to MSTRUE and MSFALSE, and I'll be opening a PR shortly implementing that.

mauro-balades commented 1 year ago

one question, why is it 1==1 instead of just 1?

Khhs167 commented 1 year ago

I don't know, I didn't implement it, so you'll have to ask hrszpuk 'bout that.

mauro-balades commented 1 year ago

he blocked me on discord lol

Khhs167 commented 1 year ago

@hrszpuk, sorry for the ping. Could you come over here and answer the question about (1 == 1) being the value of the TRUE macro?

hrszpuk commented 1 year ago

Code for the TRUE/FALSE macros were taken from your issue https://github.com/Khhs167/memstack/issues/7. It is a bit strange but I believe that’s what you wanted for the PR to pass.

Khhs167 commented 1 year ago

I must've read it somewhere then, don't really know.

Khhs167 commented 1 year ago

Anyhow, if discussion wants to continue, we'll have to do that somewhere else.

This issue is resolved in #14, so I'll be closing it now!