KhiopsML / khiops-python

The Python library of the Khiops AutoML suite
https://khiops.org
BSD 3-Clause Clear License
10 stars 1 forks source link

When openmpi is launched with the quiet flag, the return code must be handled though #250

Closed tramora closed 1 month ago

tramora commented 1 month ago

In version 10.2.2.4, openmpi is launched with the --quiet flag that shallows every error message.

It seems safe to remove this flag to give informative messages to the end user. If the flag is to be kept the return code must be evaluated otherwise openmpi exits silently without letting the user know the issue (for example when the proc number is too high)

popescu-v commented 1 month ago

IMHO, the way to go is to: 1/ Wait for https://github.com/KhiopsML/khiops/issues/310 to land into khiops (after release 10.2.3). 2/ Document the proper environment variable configuration to set, in order to tune the (Open)MPI verbosity. Hence, there is no need to modify khiops-python in this respect IMHO.

Pending this change, one temporary "escape hatch" could be to update the KHIOPS_MPI_COMMAND environment variable via a command like: export KHIOPS_MPI_COMMAND=$(echo $KHIOPS_MPI_COMMAND | sed 's/ --quiet//') Thusly, the --quiet flag would be locally removed, but this should only be used for debugging purposes IMHO, as OpenMPI output can be quite verbose AFAIK.

If this solution is OK, then this PR could be closed IMHO.