Implement automatic sort in core functions

KhiopsML / khiops-python

The Python library of the Khiops AutoML suite

https://khiops.org

BSD 3-Clause Clear License

8 stars 1 forks source link

Implement automatic sort in core functions #58

Closed popescu-v closed 1 month ago

popescu-v commented 1 year ago

Implementation ideas

Add a flag sort to train_predictor, deploy_model, train_recoder, evaluate_predictor (default False)
Traverse the tables to generate the scenario code to be executed before training
Modify sklearn estimators to just use the new sort option of core functions and eliminate calls to core.sort_data_table

popescu-v commented 1 year ago

Maybe just implement a helper function sort_dataset that takes a dictionary file or domain and sorts all tables by their key. The signature would be similar to that of train_predictor.

folmos-at-orange commented 8 months ago

The automatic sort for the sklearn module was implemented in the 10.1.1 with the internal_sort (defaults to True). The parameter proposed for core.api seems irrelevant.

When we will expose the Dataset we will implement a sort function for a multitable dataset. So, this feature will be not be necessary in core and thus is obsolete.