Crash when opening full post, only on some posts

[emmaexe]

Checklist

• [X] I have used the search function for open and closed issues to see if someone else has already submitted the same bug report.
• [X] I will describe the problem with as much detail as possible.
• [X] If the bug only occurs with a certain link, post, image..., I will include the URL.

App version

5.11.0

Where did you get the app from

Other

Android version

MIUI Global 14.0.5 (Android 12 SKQ1.211019.001)

Device model

Poco X3 NFC

First occurred

Recently, unsure exactly when since it does not happen on all posts

Steps to reproduce

1. Find a post that crashes when opened fully
2. Open post, and see that the app crashes

Example post, link, markdown...

https://www.reddit.com/r/MadeMeSmile/comments/17i55ro/oc_my_son_thinks_that_semi_trucks_are_life_it/

Expected behaviour

Post loads normally

Current behaviour

App crashes

Logs

2 Examples:

java.lang.NullPointerException: Attempt to invoke virtual method 'int org.json.JSONArray.length()' on a null object reference
    at ml.docilealligator.infinityforreddit.utils.Utils.inlineImages(Utils.java:92)
    at ml.docilealligator.infinityforreddit.comment.ParseComment.parseSingleComment(ParseComment.java:268)
    at ml.docilealligator.infinityforreddit.comment.ParseComment.parseCommentRecursion(ParseComment.java:189)
    at ml.docilealligator.infinityforreddit.comment.ParseComment.parseCommentRecursion(ParseComment.java:196)
    at ml.docilealligator.infinityforreddit.comment.ParseComment.parseCommentRecursion(ParseComment.java:196)
    at ml.docilealligator.infinityforreddit.comment.ParseComment.lambda$parseComment$1(ParseComment.java:39)
    at ml.docilealligator.infinityforreddit.comment.ParseComment$$ExternalSyntheticLambda4.run(Unknown Source:8)
    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:644)
    at java.lang.Thread.run(Thread.java:1012)

java.lang.NullPointerException: Attempt to invoke virtual method 'int org.json.JSONArray.length()' on a null object reference
    at ml.docilealligator.infinityforreddit.utils.Utils.inlineImages(Utils.java:92)
    at ml.docilealligator.infinityforreddit.comment.ParseComment.parseSingleComment(ParseComment.java:268)
    at ml.docilealligator.infinityforreddit.comment.ParseComment.parseCommentRecursion(ParseComment.java:189)
    at ml.docilealligator.infinityforreddit.comment.ParseComment.parseCommentRecursion(ParseComment.java:196)
    at ml.docilealligator.infinityforreddit.comment.ParseComment.parseCommentRecursion(ParseComment.java:196)
    at ml.docilealligator.infinityforreddit.comment.ParseComment.lambda$parseComment$1(ParseComment.java:39)
    at ml.docilealligator.infinityforreddit.comment.ParseComment$$ExternalSyntheticLambda4.run(Unknown Source:8)
    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:644)
    at java.lang.Thread.run(Thread.java:1012)

[emmaexe]

After looking at the post a little, I found this comment which might be the cause: https://www.reddit.com/r/MadeMeSmile/comments/17i55ro/comment/k6sbd3v/?utm_source=share&utm_medium=web2x&context=3

It seems reddit introduced "collectible expressions" recently: https://www.reddit.com/r/modnews/comments/17b00ch/introducing_collectible_expressions/

Not sure if that is the cause, but it might be it.

[emmaexe]

Also tested this with the same post on the original infinity, which does not have the inline image rendering and it works fine there.

[emmaexe]

From logcat:

E/MARKWON-IMAGE: Error loading image: avatar_exp|147939568|bravo
    java.lang.IllegalStateException: No scheme is found: avatar_exp|147939568|bravo
        at io.noties.markwon.image.AsyncDrawableLoaderImpl$1.run(AsyncDrawableLoaderImpl.java:96)
        at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:487)
        at java.util.concurrent.FutureTask.run(FutureTask.java:264)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:644)
        at java.lang.Thread.run(Thread.java:1012)

Occurs when attempting to render the collectible expressions comment

[KhoalaS]

Will look into it 👍

[KhoalaS]

Temp fix in a557246