KhoalaS / Infinity-For-Reddit

A Reddit client for Android
https://play.google.com/store/apps/details?id=ml.docilealligator.infinityforreddit
GNU Affero General Public License v3.0
310 stars 13 forks source link

Mismatch between github version and apk version #20

Closed emmaexe closed 10 months ago

emmaexe commented 10 months ago

Checklist

App version

5.12.0

Where did you get the app from

Other

Android version

MIUI Global 14.0.5 (Android 12 SKQ1.211019.001)

Device model

Poco X3 NFC

First occurred

No response

Steps to reproduce

No response

Example post, link, markdown...

The version of the apk/app when installed is 2023.31.0 following reddit's version scheme. However, infinity for reddit's version on github is currently 5.12.0. This mismatch causes issues when using app installers/updaters like obtainium since github releases reports the latest version differently from the app itself. Since the app isn't available on repositories like f-droid, it would be nice if it functioned better with obtainium. Obtainium does have built-in estimation for situations like this but it is not perfect, and does not work in all situations.

obtainium

Expected behaviour

Version on github matches actual app version or vice versa.

Current behaviour

Versions don't match. There is no version detection available. The app thinks there is an update, even though I have 5.12.0 installed.

Logs

No response

KhoalaS commented 10 months ago

Yeah, I did this cause the app version is sometimes pulled for some generic network calls. I willI start incrementing/releasing the versions according to Reddits scheme on the next release.