KhoalaS / Infinity-For-Reddit

A Reddit client for Android
https://play.google.com/store/apps/details?id=ml.docilealligator.infinityforreddit
GNU Affero General Public License v3.0
310 stars 13 forks source link

Material You theme does not update upon launch of app #4

Closed coxackie closed 11 months ago

coxackie commented 1 year ago

Checklist

App version

5.8.0

Where did you get the app from

Other

Android version

13

Device model

No response

First occurred

No response

Steps to reproduce

  1. Choose "Material You" theme
  2. Close the application
  3. Change wallpaper
  4. Enter Infinity
  5. Colour palette is the same as before

Example post, link, markdown...

No response

Expected behaviour

Material you theme should attempt to update the palette every time that the app launches

Current behaviour

Material You theme is applied once selected at the current derived colour scheme and does not update is the wallpaper changes. One can only update it manually.

Logs

No response

KhoalaS commented 1 year ago

Fixed in 8e170d8cdeafa63ca3a1c53830c2a088f1825ddd. Will be included in next release.

coxackie commented 1 year ago

@KhoalaS thanks a lot for this. Just a quick question: I see this checks for wallpaper change upon app launch. What happens with live wallpapers that change (for example, with time of the day or weather)? The wallpaper itself will not have changed, it would just be a different instance of the live wallpaper.

KhoalaS commented 1 year ago

The original implementation uses Intent Filters that check for a wallpaper change. It will not update the colors if a live wallpaper changes it's colors. I'll look into it though.