KhoonSun47 / pe

0 stars 0 forks source link

Able To Accept Invalid Email Addresses #10

Open KhoonSun47 opened 4 months ago

KhoonSun47 commented 4 months ago

Steps to reproduce:

  1. Currently, the system did not strictly adhere to IETF standards for email addresses.
  2. When the user tries to enter an invalid email addresses to the system, the system deemed it as valid
  3. One example of an invalid email address is "abc@12.34"

Actual Output: Step 1: Entering an invalid email address "abc@12.34" to this person "John LOL" image.png

Expected Output: This should be rejected as it is an invalid email address.

Suggestion: I believe that the validation for the email address could be stricter, to follow the format for the IETF standards.

soc-pe-bot commented 4 months ago

Team's Response

Hello, thank you for sharing your observation regarding email validation!

However, we'd like to point out that the case you've mentioned, where an invalid email address like "abc@12.34" is accepted, typically occurs when there's a user error during data entry ie HR manager type wrongly. These instances are very rare, as they require incorrect input that deviates significantly from common patterns of email addresses. Given that the majority of users are HR managers who are familiar with standard email address formats, this scenario should not be common in everyday use.

While we acknowledge that the system's validation could be stricter to align with IETF standards, we believe the impact of this issue is limited to extreme cases. Nonetheless, we will consider your feedback as future enhancements to HR Connect.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: [replace this with your explanation]


## :question: Issue severity Team chose [`severity.VeryLow`] Originally [`severity.Low`] - [x] I disagree **Reason for disagreement:** I disagree with the reduction in severity of this response, maintaining that it should remain classified as "severity.Low" rather than "severity.VeryLow." 
 This bug is not merely cosmetic and it affects functionality. 
 This is because there is still a risk that an HR manager could enter an invalid email into the system, and the application lacks stringent email validation. ![severity.VeryLow A flaw that is purely cosmetic and does not affect usage.png](https://raw.githubusercontent.com/KhoonSun47/pe/main/files/b23ee8c6-ff74-4444-986b-43929e25ca97.png)