KhoonSun47 / pe

0 stars 0 forks source link

JSON Format Being Corrupted #11

Open KhoonSun47 opened 4 months ago

KhoonSun47 commented 4 months ago

Steps to reproduce:

Actual Output: Step 1: The user went to JSON file and change the field name of "tags" to something else and save it. image.png

Step 2: The user went to run the system as per normal on the terminal. image.png

Expected Output: It should be invalidated and displayed an empty list instead.

One example on how it should be validated. Step 1: The user went to JSON file and change the field name of "name" to something else and save it. image.png

Step 2: The user went to run the system as per normal on the terminal. As you can see here, the data is invalidated and the displayed list is empty image.png

Suggestion: Add validation to check for the field name "tags" to be validated.

soc-pe-bot commented 4 months ago

Team's Response

Thanks for bringing up the issue. As per the user guide, editting data file will cause unexpected behaviour and this is expected. So, to further validate such error, it could be a future enhancement. And user would rarely edit it unless they are advanced user as specified by the user guide.

image.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: I disagree that this response is "response.NotInScope" and that it should be "response.Accepted" instead. 


According to the User Guide, any modifications to the data file that invalidate its format prompt HRConnect to discard all data and restart with an empty file. 


Thus, altering the "tags" field name implies corruption of the file (as the format is invalid), warranting a check for this corruption and the display of an empty list thereafter.

image.png


## :question: Issue type Team chose [`type.FeatureFlaw`] Originally [`type.FunctionalityBug`] - [x] I disagree **Reason for disagreement:** I disagree that this issue should be classified as a "type.Feature Flaw”, and it should still be remained as a “type.Functionality Bug”. 
 As stated on the website, a “Functionality Bug” covers manual edits to the data file. ![Handling manual edits to the data file AB3 UG specifies the current level of.png](https://raw.githubusercontent.com/KhoonSun47/pe/main/files/925251c7-878f-4ec5-85da-ea322bbdc3e6.png)
## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [x] I disagree **Reason for disagreement:** I disagree to the downgrading of this response's severity from "severity.Medium" to "severity.Low." 
 If HR managers, particularly advanced users, modify the data and then discover that not all fields are validated, it can lead to confusion and occasional inconvenience. 
 The product still functions, but this oversight can impair the user experience for those who manually edit the data file. ![• severity-Medium A flaw that causes occasional inconvenience to some users,.png](https://raw.githubusercontent.com/KhoonSun47/pe/main/files/935ee8d4-f4f6-4d3c-854c-6a26b42d702f.png)