Open KhoonSun47 opened 4 months ago
Thanks for bringing up the issue. As per the user guide, editting data file will cause unexpected behaviour and this is expected. So, to further validate such error, it could be a future enhancement. And user would rarely edit it unless they are advanced user as specified by the user guide.
Team chose [response.NotInScope
]
Reason for disagreement: I disagree that this response is "response.NotInScope" and that it should be "response.Accepted" instead.
According to the User Guide, any modifications to the data file that invalidate its format prompt HRConnect to discard all data and restart with an empty file.
Thus, altering the "tags" field name implies corruption of the file (as the format is invalid), warranting a check for this corruption and the display of an empty list thereafter.
Steps to reproduce:
Actual Output: Step 1: The user went to JSON file and change the field name of "tags" to something else and save it.![image.png](https://raw.githubusercontent.com/KhoonSun47/pe/main/files/e0b1d338-cbaf-4820-9820-989d9d4fd416.png)
Step 2: The user went to run the system as per normal on the terminal.![image.png](https://raw.githubusercontent.com/KhoonSun47/pe/main/files/e7c7b8eb-fffb-45ea-a48b-498dfbbf9538.png)
Expected Output: It should be invalidated and displayed an empty list instead.
One example on how it should be validated. Step 1: The user went to JSON file and change the field name of "name" to something else and save it.![image.png](https://raw.githubusercontent.com/KhoonSun47/pe/main/files/0d3f2c5a-ce3e-4e30-9cdc-e267a0ff4024.png)
Step 2: The user went to run the system as per normal on the terminal. As you can see here, the data is invalidated and the displayed list is empty![image.png](https://raw.githubusercontent.com/KhoonSun47/pe/main/files/49733deb-2a6e-4a21-9a18-3a80a58e5128.png)
Suggestion: Add validation to check for the field name "tags" to be validated.