KhoonSun47 / pe

0 stars 0 forks source link

Not Enough Details on Implementations #17

Open KhoonSun47 opened 6 months ago

KhoonSun47 commented 6 months ago

There are many commands in your applications, however, not all commands implementations are covered in the DG.

List of Implementations in the DG: image.png

List of Commands in the UG: image.png

nus-se-bot commented 6 months ago

Team's Response

The reported issue does not affect the quality of the documentation. The team thinks the features that are not included are trivial and do not require detailed explaination so not all the features are explained. Hence, it is rejected. Thanks!

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: I disagree that this issue should be classified as "response.Rejected," and believe that it should be categorised as "response.Accepted" instead.

According to standard guidelines outlined in textbooks, the primary objective of a Developer Guide (DG) is to showcase your team's documentation skills.

It is intended not only to explain the design and implementation to future developers but also to demonstrate your team's capability to document deeply technical content effectively through prose, examples, diagrams, code snippets, and more.

Not documenting critical features in your application such as filter, export, and import (CLI) in the DG could significantly hinder future developers who may take over the project.

These features, which are not part of the standard AB3 AddressBook functionality, require documentation to aid in the readers in understanding their implementation and integration into the existing system.

By omitting these features documentation, it could potentially lead to confusion about how these features operate and their relevance to the overall application.

image.png

image.png