KhronosGroup / COLLADA2GLTF

COLLADA to glTF converter
Other
538 stars 157 forks source link

Incorrect Texture Mapping #199

Open apptaro opened 6 years ago

apptaro commented 6 years ago

Some of converted GLTF files have incorrect texture mappings:

summary
apptaro commented 6 years ago

Version: COLLADA2GLTF-v2.1.2-windows-Release-x64

DAE and GLTF data attached: data-uv.zip

Possibly related issue: #174, #175, #116

apptaro commented 6 years ago

All DAE files are exported from 3ds Max. BabylonJS, Three.js and Cesium all render in the same way.

lasalvavida commented 6 years ago

This should be mostly fixed in the latest version of #180 that allows for multiple texture maps.

screenshot from 2018-07-20 08 29 01

screenshot from 2018-07-20 08 29 57

screenshot from 2018-07-20 08 30 24

There's a little bit of weirdness on one of the bulbs in the lamp model still, and I'm not sure what the cause is yet.

screenshot from 2018-07-20 08 30 49

apptaro commented 6 years ago

@lasalvavida wow, very nice, I'm looking forward to the next release. I have many other cases with this issue, so once the fix is released, I will try them all.

apptaro commented 6 years ago

any plan to release the fix?

lasalvavida commented 6 years ago

Hey @apptaro. It will be released once I have tested it more thoroughly.

If you want to use it/help test it in the meantime, you can grab pre-built artifacts for windows off of the appveyor job for the pull request like this one: Windows x64 Release multiple-maps

apptaro commented 6 years ago

@lasalvavida Yes, I would like to use and test it. I downloaded the one above, but it has the issue #200 and was not usable.

lasalvavida commented 6 years ago

Sounds good, #200 is next on my list.

apptaro commented 6 years ago

@lasalvavida Let me know when I can test it out.

apptaro commented 6 years ago

@lasalvavida Now I have figured out how to get the latest build from appveyor job, and tested it out. About 50 models are fixed. I have some models that still have the same issue, and some different issues. I will let you know when I am done testing.

lasalvavida commented 6 years ago

Thanks @apptaro - the testing is very much appreciated!

Ld-LaoWu commented 6 years ago

I'm very looking forward that,but this is my stuff for multiple-maps and let that support THREE.js

apptaro commented 6 years ago

@lasalvavida After testing all my models, only cases with this issue are dress-pendant-light-l-black.dae (above) and dress-pendant-light-l-white.dae (attached here data2.zip)

Tested with Build 2.0.314, COLLADA2GLTF-master-windows-Release-x64.zip

Ld-LaoWu commented 6 years ago

image @lasalvavida it'my model .lightmap and diffusemap ,SO I have two layers of texture uvs for that and i I have modifieded the struct of outgltf and made it satisfied with it. and I want to compile your program so that i can control what i can output.can you give me a corrent program on windows? Waiting online,(i can not solve the erro about camke's Compiling)

lasalvavida commented 6 years ago

@mycleaerlife, you can download Windows builds for any commit from the corresponding AppVeyor job artifacts tab like this one.

Ld-LaoWu commented 6 years ago

@lasalvavida I‘m sorry for that's wrong about my test, can i get source code ,and Compling it by myself.and sorry for my english image