search

KhronosGroup / DockerContainers

Docker container specifications which package dependencies for building Khronos documentation and software
Apache License 2.0
7 stars 10 forks source link

Add dos2unix tool for the SPIR-V workflow #38

Closed Naghasan closed 5 months ago

Naghasan commented 6 months ago

The SPIR-V specs and extension workflow uses the tools, adding this to the base image so it is usable by the group.

Naghasan commented 5 months ago

@oddhack / @rpavlik I'm not sure who owns the repo, could I have some eyes on this PR ? Thanks

oddhack commented 5 months ago

@oddhack / @rpavlik I'm not sure who owns the repo, could I have some eyes on this PR ? Thanks

You should be able to run the image from dockerhub now. Since there are varied weird caching issues we've encountered inside and outside CI that make it hard to say just which version you'll get when invoking the 'asciidoctor-spec' image by name, I've found the most reliable way is to include the SHA, e.g.

docker run {args} khronosgroup/docker-images:asciidoctor-spec@sha256:fb9a87a8a8a921820b9cae6c05fa1c12aa52beef485485d00e6e99f1e8148baf /bin/bash

Naghasan commented 5 months ago

Thanks Jon