search

KhronosGroup / DockerContainers

Docker container specifications which package dependencies for building Khronos documentation and software
Apache License 2.0
7 stars 10 forks source link

Update asciidoctor-spec image to ruby:3.3.3 #40

Closed oddhack closed 2 months ago

oddhack commented 2 months ago

This greatly reduces the number of CVEs reported by Dockerhub and also updates the toolchain to current versions of asciidoctor (which apparently gives some better error messages now than it used to).

Because of the underlying Debian updates, Python packages can no longer be installed at system level without a very ugly and brute-force override. Instead this image sets up a Python virtual environment containing all the packages, with just enough of an OS-level Python to install venv itself. If you are following the image instructions to do your own non-Docker install of the toolchain, you will need to setup a venv and then use the 'activate' script or otherwise setup your VIRTUAL_ENV and PATH to use that version. Scripts relying on Python packages installed by this image must invoke the python3 in the venv, not /usr/bin/python3.

oddhack commented 2 months ago

@rpavlik headsup for you if updating to a newer base image about the Debian / Python system package install restriction change, that might affect your Dockerfiles as well.

oddhack commented 2 months ago

SYCL has https://github.com/KhronosGroup/SYCL-Docs/pull/576 queued up to use the updated image and migrate to specifying by SHA instead of just by name, and I have a comparable internal MR that will go out soon for Vulkan-Docs and have verified Actions works with the image, so calling this good.