search

KhronosGroup / EGL-Registry

EGL API and Extension Registry
115 stars 105 forks source link

Don't let KHRONOS_STATIC affect the calling convention #106

Closed mstorsjo closed 4 years ago

mstorsjo commented 4 years ago

When intending to link statically, we should leave out declspec(dllimport), but the calling convention (stdcall) should still be the same.

This reverts parts of commit 94ba8ee876206364cf45a9bc08b8db5a52cb9543, making the exception to stdcall specific to SCITECH_SNAP__ again as it was before.

stonesthrow commented 4 years ago

Reference: https://github.com/KhronosGroup/EGL-Registry/pull/81

mstorsjo commented 4 years ago

Thanks!

Well, with the previous change, if they applied KHRONOS_STATIC consistently both when building libEGL and the caller of it, it shouldn't change anything (it will use a different calling convention but both change in sync).

If libEGL and the caller didn't both use KHRONOS_STATIC (but was built for static linking by other means, e.g. the build of libEGL did -DEGLAPI=, which happens e.g. when ANGLE is built as part of Qt), it's currently impossible to link against it using KHRONOS_STATIC.

So in short, cases that worked before should still work, and it should fix mismatches in other cases.

stonesthrow commented 4 years ago

Can be closed.