search

KhronosGroup / GLSL

GLSL Shading Language Issue Tracker
324 stars 96 forks source link

Vulkan reserved keywords are missing from the GLSL ES 3.2 Spec #212

Open teoxoy opened 11 months ago

teoxoy commented 11 months ago

Comparing the GLSL 4.6 keywords with the GLSL ES 3.2 keywords, I noticed the following Vulkan keywords were missing from the GLSL ES 3.2 reserved keywords section.

texture1DArray
utexture2DRect
utexture1DArray
texture2DRect
texture1D
itexture1D
itexture1DArray
utexture1D
itexture2DRect

https://github.com/KhronosGroup/OpenGL-Registry/blob/d00e11dc1a1ffba581d633f21f70202051248d5c/specs/gl/GLSLangSpec.4.60.html#L2004-L2322

https://github.com/KhronosGroup/OpenGL-Registry/blob/d00e11dc1a1ffba581d633f21f70202051248d5c/specs/es/3.2/GLSL_ES_Specification_3.20.html#L2166-L2478

gnl21 commented 10 months ago

So these keywords are added by GL_KHR_vulkan_glsl to the desktop version of the spec, but they were not reserved before that extension in either GL or ES. The extension doesn't say what should happen to the 1D version of the keywords in ES, where 1D textures are not supported, but I agree that making them reserved would be the sensible thing to do. If the working group agrees then I'll update the spec.