search

KhronosGroup / KTX-Software

KTX (Khronos Texture) Library and Tools
Other
877 stars 229 forks source link

Fixing vendor-specific/tied memory property flag detection #771

Closed toomuchvoltage closed 1 year ago

toomuchvoltage commented 1 year ago

Fixing vendor-specific/tied memory property flag detection for vkloadtests's VMA wrapper.

toomuchvoltage commented 1 year ago

Dear @MarkCallow , this should fix the reported issue. Though would appreciate a quick smoke test on the M2 device as well just to be sure.

MarkCallow commented 1 year ago

Though would appreciate a quick smoke test on the M2 device

It works.

MarkCallow commented 1 year ago

For orthogonality please add `ktxTexture[12]_VkUploadEx_WithSuballocator wrappers to vkloader.c. I hadn't noticed they weren't there in the previous PR.

toomuchvoltage commented 1 year ago

For orthogonality please add `ktxTexture[12]_VkUploadEx_WithSuballocator wrappers to vkloader.c. I hadn't noticed they weren't there in the previous PR.

All done! Let me know if this suffices. 🙏

MarkCallow commented 1 year ago

Thanks again.

toomuchvoltage commented 1 year ago

Thanks again.

You're very welcome Mark. I feel privileged to have been able to contribute.