search

KhronosGroup / KTX-Software

KTX (Khronos Texture) Library and Tools
Other
875 stars 230 forks source link

KTXwriterScParams support #779

Closed aqnuep closed 1 year ago

aqnuep commented 1 year ago

Fixes #758.

Depends on the CTS PR https://github.com/KhronosGroup/KTX-Software-CTS/pull/5.

@MarkCallow FYI (please make sure you merge the CTS PR first with rebasing policy).

MarkCallow commented 1 year ago

Please rebase to get the MinGW fix.

Looks good but the repetition of so many string values is unfortunate. Is there a way to reduce the repetition? If not, please define a const string object for each value and refer to that at each place where needed.

aqnuep commented 1 year ago

Please rebase to get the MinGW fix.

Looks good but the repetition of so many string values is unfortunate. Is there a way to reduce the repetition? If not, please define a const string object for each value and refer to that at each place where needed.

Yeah, I tried to minimize that, in fact eliminated one of them. We could use some consts, sure.

MarkCallow commented 1 year ago

Yeah, I tried to minimize that, in fact eliminated one of them. We could use some consts, sure.

Please do it.

Note that my e-mail service is currently broken. I can neither send nor receive messages from my regular addresses. Therefore my responses may be somewhat delayed.

aqnuep commented 1 year ago

I've rebased and added string constants for all the places where it made sense. This should be fine once CI passes.

I can neither send nor receive messages from my regular addresses.

Is there any channel through which we can contact you privately in the meantime?

MarkCallow commented 1 year ago

Is there any channel through which we can contact you privately in the meantime?

I've just sent you a message from it.

aqnuep commented 1 year ago

Removed "astc-mode" option, as requested. Instead, default to LDR mode for UNORM/SRGB.

aqnuep commented 1 year ago

Updated CTS git submodule hash. Ready for merge.