KTX compare tool - phase 1

KhronosGroup / KTX-Software

KTX (Khronos Texture) Library and Tools

Other

861 stars 225 forks source link

KTX compare tool - phase 1 #815

Closed aqnuep closed 7 months ago

aqnuep commented 9 months ago

Draft implementation for the compare tool with no image comparison yet. Basic test set covering the following:

Help
Command line errors
Use with invalid files without the "allow-invalid-input" flag
Use with invalid files with the "allow-invalid-input" flag
Unicode filename support

Note: This PR contains the changes in PR #809 too, because the CTS is based on the CTS main branch which already got merged, yet the code wasn't, so there was no other way to make tests pass otherwise.

MarkCallow commented 9 months ago

Note: This PR contains the changes in PR https://github.com/KhronosGroup/KTX-Software/pull/809 too because the CTS is based on the CTS main branch which already got merged, yet the code wasn't

Sorry about that. I've been waiting for @lexaknyazev's review. Since he already agreed to the behavior change to an error and the changes are fairly minor I'll merge it now.

aqnuep commented 9 months ago

Sorry about that. I've been waiting for @lexaknyazev's review. Since he already agreed to the behavior change to an error and the changes are fairly minor I'll merge it now.

No worries, just wanted to be up-front to expect that unrelated change showing up in this PR.

aqnuep commented 9 months ago

This PR is now fully tested with the tests in PR https://github.com/KhronosGroup/KTX-Software-CTS/pull/13 and fixed accordingly. It should be ready for review, I just left the PR as draft because there will be a need to update the CTS commit reference. @MarkCallow, let me know if you have any questions or comments.

MarkCallow commented 8 months ago

To fix the Travis build you will need to rebase to current main (4.3.0-beta1) which has the fix for the Emscripten build issue.

aqnuep commented 8 months ago

FYI: since it seems this and the corresponding CTS PR https://github.com/KhronosGroup/KTX-Software-CTS/pull/13 is unlikely to get merged before we proceed with the image diff part of the implementation, we've started working on that here, so likely we'll have one pair of large PRs in the end.