search

KhronosGroup / KTX-Software

KTX (Khronos Texture) Library and Tools
Other
854 stars 226 forks source link

Add license, license_files, long_description_content_type, long_description in pyktx setup.py #844

Closed ShukantPal closed 6 months ago

ShukantPal commented 6 months ago

@MarkCallow https://github.com/KhronosGroup/KTX-Software/pull/698#issuecomment-1891222766

MarkCallow commented 6 months ago

This PR fixed the previous problems. Now deploy is almost working but now I get this error:

ERROR    HTTPError: 400 Bad Request from https://test.pypi.org/legacy/          
         Binary wheel 'pyktx-4.3.0-cp310-cp310-linux_aarch64.whl' has an        
         unsupported platform tag 'linux_aarch64'.

What is the proper tag? Please fix the platform tag.

MarkCallow commented 6 months ago

Looking at this page it seems we should use manylinux not linux. See also this. Please advise.

MarkCallow commented 6 months ago

Please fix the platform tag.

Please make sure all the platform tags are correct. The one mentioned in the error is the first .whl in the list. It takes over 2 hours for CI to build and deploy all the release packages (can't build just the .whl packages without massive changes to the CI set up) so I don't want to find that this linux package is fixed and some other package is (still) broken after the next build.

MarkCallow commented 6 months ago

As I told you before we also still need to find an alternative to kittaakos/upload-artifact-as-is as it uses version 12 of node.js which has been removed from GitHub Actions so the action is forced to run on node 16. There seems to be no problem with it doing so but node 16 is deprecated and will be removed at which point it will be forced to use node 20. Then who knows. Plus the warning is ugly. The GitHub project has been archived and hasn't been touched in 4 years.

This is much less urgent than the platform tag as it is not a showstopper for the 4.3.0 release.

ShukantPal commented 6 months ago

Building manylinux-compatible wheels is not trivial

The binary wheels are not essentials for publishing the package; since pip will auto build pyktx against the system libktx on install time, it's best to remove linux wheels from the publishing process.

ShukantPal commented 6 months ago

https://github.com/KhronosGroup/KTX-Software/pull/845