search

KhronosGroup / KTX-Software

KTX (Khronos Texture) Library and Tools
Other
854 stars 226 forks source link

KTX Compare Tool - Phase 2 #863

Closed aqnuep closed 5 months ago

aqnuep commented 5 months ago

This now includes the complete implementation for the compare tool, as of the baseline, but once this is merged to the ktx-compare branch and that branch will result in a rebased PR against main, then I expect some minor changes.

This change also solves the issues that resulted in invalid golden files, because some of the compare tool testing depended on fixing the cause of those.

aqnuep commented 5 months ago

@MarkCallow, please review this change indifferent of the fact that it is a draft and CI may not pass yet.

This will anyway first go into the ktx-compare branch for finalization, rebasing, etc. before the final PR to main.

Thanks!

aqnuep commented 5 months ago

Hi @MarkCallow! Do you need more time to review this or the related CTS change or should I proceed with merging these into the ktx-compare development branch?

MarkCallow commented 5 months ago

Do you need more time to review this or the related CTS change

I just attempted a review. Please see my comment over there.

MarkCallow commented 5 months ago

Do you need more time to review this or the related CTS change

I just attempted a review. Please see my comment over there.

The changes in this PR are fine. I am in the midst of a very busy period. I won't have time to start trying ktx compare until the middle of next week. I don't want to hold you up any more so go ahead and merge the CTS changes and this.

aqnuep commented 5 months ago

Thank you, @MarkCallow. I'll get everything merged in the ktx-compare development branch and then we'll start rebasing/integrating mainline chaines into that development branch, because that'll take some time too. After that I still intend to open PRs before merging the development branch into main, so you'll have the chance to do another review round and testing, as necessary.

aqnuep commented 5 months ago

@MarkCallow, do what's going on with one of the Windows CI builds?

I'm getting this error message:

Installing the following packages:
doxygen.install
By installing, you accept licenses for the packages.
Invalid credentials specified.
Please provide credentials for: https://community.chocolatey.org/api/v2/
User name: Password: Chocolatey had an error on fv-az1201-[60](https://github.com/KhronosGroup/KTX-Software/actions/runs/8221005561/job/22481055168?pr=863#step:5:61)3 (with user runneradmin):
System.InvalidOperationException: Cannot read keys when either application does not have a console or when console input has been redirected from a file. Try Console.Read.
MarkCallow commented 5 months ago

I'm getting this error message:

...

This is a recurring issue with Chocolatey. It is one of the reasons CI tries 4 times to download Doxygen before failing. I do not fully understand it and have not had much help from GitHub. I just tried re-running but it failed again. I suggest trying to re-run tomorrow.