Flesh out support for VK_FORMAT_R16G16_S10_5_NV.

KhronosGroup / KTX-Software

KTX (Khronos Texture) Library and Tools

Other

854 stars 226 forks source link

Flesh out support for VK_FORMAT_R16G16_S10_5_NV. #864

Closed MarkCallow closed 5 months ago

MarkCallow commented 5 months ago

Code is believed complete. Tests have yet to be added. Hence draft status.

This includes a new round-trip test of vk2dfd and dfd2vk for all Vulkan formats except multi-plane and modifications to both functions, or rather their generators, to fix support for some formats, including VK_FORMAT_R16G16_S10_5_NV and the YUV 422 single plane formats. Those listed required changes tointerpretDFD.

Fixes #859.

MarkCallow commented 5 months ago

@fluppeteer, please review. I was unable to add your GitHub id to the reviewers list.

fluppeteer commented 5 months ago

I think this mostly looks good, except that the multi-channel packing convention wires got crossed. I've added notes where I think the numbers should be different. Please poke me if you change them and want a re-review, or want to push back; I'll try to respond promptly this time.

fluppeteer commented 5 months ago

The #define approach looks much easier to read (not a phrase I'll often say) - thanks for clarifying, and sorry again to have caused the churn!

Assuming all the test are happy, I think this is good to go, and we can talk about coordinate offsets separately.