search

KhronosGroup / KTX-Software

KTX (Khronos Texture) Library and Tools
Other
834 stars 222 forks source link

Expose supercompression functions via JNI #879

Closed javagl closed 3 months ago

javagl commented 3 months ago

Updated:

This builds upon https://github.com/KhronosGroup/KTX-Software/pull/876 , which is already merged.

It exposes the deflateZstd and deflateZLIB functions of the ktxTexture2 class to the Java KtxTexture2 class.

This is only a tiny part of the changes that are contained in https://github.com/KhronosGroup/KTX-Software/pull/886 , but could be merged independently.

MarkCallow commented 3 months ago

@javagl I will be away from Thursday morning for 10 days. If you can make the requested changes and merge the changes from main before 22:00 JST (13:00 UTC) today I can merge before I leave otherwise it will have to wait.

javagl commented 3 months ago

... merge before I leave otherwise it will have to wait.

As I just mentioned in https://github.com/KhronosGroup/KTX-Software/pull/876#issuecomment-2022693341 : It's not time-critical. There are different options for the merge order. And merge conflicts are unlikely.

So we don't have to do anything hastily. I'll try to fix the test for the swizzle PR, wrap up this one, and then continue with the 'JNI improvements' one, and we can talk about the merging details when you are back.