Closed javagl closed 3 months ago
Sorry, I'm pedantic
No apology necessary.
I'm pretty sure that the codecName at
KTX-Software/tools/ktx/encode_utils.h
Line 269 in 7a45c4e std::string codecName; is not used and could be removed.
This part of the source is about to be refactored. It will be dealt with then.
Sorry, I'm pedantic. Some minor documentation fixes:
isCubemap
should beisCompressed
: https://github.com/KhronosGroup/KTX-Software/blob/7a45c4e6159c0815e4663a529a1e718136a16e39/include/ktx.h#L329n
at https://github.com/KhronosGroup/KTX-Software/blob/7a45c4e6159c0815e4663a529a1e718136a16e39/include/ktx.h#L341<
at https://github.com/KhronosGroup/KTX-Software/blob/7a45c4e6159c0815e4663a529a1e718136a16e39/tools/ktx/command_create.cpp#L765../
in https://github.com/KhronosGroup/KTX-Software/blob/7a45c4e6159c0815e4663a529a1e718136a16e39/pkgdoc/toolsDoxyLayout.xml#L41 and related files (I.e. on https://github.khronos.org/KTX-Software/libktx/index.html , the link to pyktx is a 404), see https://github.com/search?q=repo%3AKhronosGroup%2FKTX-Software%20%22pyktx%20Reference%22&type=codeBeyond that:
I'm pretty sure that the
codecName
at https://github.com/KhronosGroup/KTX-Software/blob/7a45c4e6159c0815e4663a529a1e718136a16e39/tools/ktx/encode_utils.h#L269 is not used and could be removed. But this would not be a plain documentation fix. So I'd rather ask whether this can be removed (and whether this should/could be part of this PR)