Closed MarkCallow closed 1 year ago
LGTM. Please also update the line 880 to allow KHR_DF_MODEL_YUVSDA
, since the spec allows YUV formats in general.
LGTM. Please also update the line 880 to allow
KHR_DF_MODEL_YUVSDA
, since the spec allows YUV formats in general.
Happy to do it but under what circumstances should this be allowed? All the Vulkan formats appear to be RGB.
Although they are called RGB, some of them require a sampler Y′CBCR conversion as stated here. The conversion may be a no-op (RGB identity), so both RGB and YUV models should be allowed for those formats.
Filtering the current KTX format list, a sampler Y′CBCR conversion is required for
*_422_*
VK_FORMAT_R10X6G10X6B10X6A10X6_UNORM_4PACK16
and VK_FORMAT_R12X4G12X4B12X4A12X4_UNORM_4PACK16
This however does not mean that it cannot be used with others.
Please also update the line 880 to allow
KHR_DF_MODEL_YUVSDA
Please take a look at latest commit.
@lexaknyazev please approve the latest small clarification.
This however does not mean that it cannot be used with others.
I am using "should" so the clarification does not rule out using YUV with other formats.
@lexaknyazev please review. I want to give direction for how the transferFunction for possible new formats should be handled as the spec already says that formats added to the Vulkan spec. in future can be used.