KhronosGroup / KTX-Specification

KTX file format source
Other
69 stars 12 forks source link

Future proof transferFunction restrictions. #191

Closed MarkCallow closed 1 year ago

MarkCallow commented 1 year ago

@lexaknyazev please review. I want to give direction for how the transferFunction for possible new formats should be handled as the spec already says that formats added to the Vulkan spec. in future can be used.

lexaknyazev commented 1 year ago

LGTM. Please also update the line 880 to allow KHR_DF_MODEL_YUVSDA, since the spec allows YUV formats in general.

MarkCallow commented 1 year ago

LGTM. Please also update the line 880 to allow KHR_DF_MODEL_YUVSDA, since the spec allows YUV formats in general.

Happy to do it but under what circumstances should this be allowed? All the Vulkan formats appear to be RGB.

lexaknyazev commented 1 year ago

Although they are called RGB, some of them require a sampler Y′CBCR conversion as stated here. The conversion may be a no-op (RGB identity), so both RGB and YUV models should be allowed for those formats.

Filtering the current KTX format list, a sampler Y′CBCR conversion is required for

This however does not mean that it cannot be used with others.

MarkCallow commented 1 year ago

Please also update the line 880 to allow KHR_DF_MODEL_YUVSDA

Please take a look at latest commit.

MarkCallow commented 1 year ago

@lexaknyazev please approve the latest small clarification.

This however does not mean that it cannot be used with others.

I am using "should" so the clarification does not rule out using YUV with other formats.