search

KhronosGroup / KTX-Specification

KTX file format source
Other
69 stars 12 forks source link

Revision 2 preparations #199

Closed MarkCallow closed 1 year ago

MarkCallow commented 1 year ago

Fixes the conflict between the statement about orientation of the blocks in an ETC1S slice and the description of the decoder operation using left-down, left and above. Also fixes 2 very minor issues discovered since the last attempt to release this.

@lexaknyazev I believe fixing this conflict fixes your objection to releasing this spec. revision. I'm guessing since I have never received an answer from you to my queries. Please review this. It is way past time this revision was released. See PR #196 for a diff of the changes between the ETC1S specs in the last published revision and after their move to separate files in the appendices folder. The changes since then can be seen in this PR.

MarkCallow commented 1 year ago

This is now complete and ready for release as far as I'm concerned. @lexaknyazev if you have any further objections please raise them now. Otherwise I will merge this then request approval to formally release.

lexaknyazev commented 1 year ago

nit: the spec comment for the num_blocks_x expression was not updated in 035a287b5eec5c244b6ed319750718927fb56b95. https://github.com/KhronosGroup/KTX-Specification/blob/035a287b5eec5c244b6ed319750718927fb56b95/ktxspec.adoc?plain=1#L251-L254

MarkCallow commented 1 year ago

Thank you. Fixed in 4bbbdf1.