Mvk cx patched - Githubissues

KhronosGroup / MoltenVK

MoltenVK is a Vulkan Portability implementation. It layers a subset of the high-performance, industry-standard Vulkan graphics and compute API over Apple's Metal graphics framework, enabling Vulkan applications to run on macOS, iOS and tvOS.

Apache License 2.0

4.64k stars 402 forks source link

Mvk cx patched #2188

Closed italomandara closed 3 months ago

CLAassistant commented 3 months ago

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
3 out of 4 committers have signed the CLA.

:white_check_mark: rcombs
:white_check_mark: italomandara
:white_check_mark: js6i
:x: nastys
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

italomandara commented 3 months ago

@billhollings Apologies, This Draft was created by mistake, and should be removed from the repo.

billhollings commented 3 months ago

@billhollings Apologies, This Draft was created by mistake, and should be removed from the repo.

No worries.

Unfortunately, I don't know of any way to fully delete a PR on GitHub. It's closed, but still visible.

It's fine to leave it like that, but if you need to remove any sensitive content, you'll have to revert the content locally, and force push to this PR again.

italomandara commented 3 months ago

@billhollings Apologies, This Draft was created by mistake, and should be removed from the repo.

No worries.

Unfortunately, I don't know of any way to fully delete a PR on GitHub. It's closed, but still visible.

It's fine to leave it like that, but if you need to remove any sensitive content, you'll have to revert the content locally, and force push to this PR again.

they (Github) remove close PRs upon request but only if there's sensitive data exposed and only if the owner of the repo is requesting it. Just found out, I remember requesting that once so not sure if they limited that when there's sensitive data involved lately.

billhollings commented 3 months ago

they (Github) remove close PRs upon request but only if there's sensitive data exposed and only if the owner of the repo is requesting it. Just found out, I remember requesting that once so not sure if they limited that when there's sensitive data involved lately.

Do you need it deleted due to sensitive content? And if so, before I submit a support request, are you able to remove it with an amend commit and force push to this PR?

italomandara commented 3 months ago

they (Github) remove close PRs upon request but only if there's sensitive data exposed and only if the owner of the repo is requesting it. Just found out, I remember requesting that once so not sure if they limited that when there's sensitive data involved lately.

Do you need it deleted due to sensitive content? And if so, before I submit a support request, are you able to remove it with an amend commit and force push to this PR?

No it's just to not pollute your repo