Closed billhollings closed 2 months ago
Sorry about that. Took me a while to get through this massive refactoring.
No apology needed. And thanks.
I wrote the Note to reviewers above so you could skip all the search & replace noise. But I appreciate your epic diligence and accuracy once again! 👍🏻
This is a non-functional code-maintenance change.
Previously,
MVKDevice
contained a significant amount of publicly exposed internal content. This patch adds functions toMVKDeviceTrackingMixin
to better encapsulate, consolidate & streamline access to this content.MVKDeviceTrackingMixin
a friend ofMVKDevice
&MVKPhysicalDevice
.MVKDevice
content behindMVKDeviceTrackingMixin
functions.MVKDevice
content pointers fromMVKCommandEncoder
.MVKDevice
removegetPhysicalDevice()
,getPixelFormats()
&getMTLDevice()
, to focus access throughMVKDeviceTrackingMixin
.MVKDeviceTrackingMixin
to remove need to referenceMVKDevice
multiple times when marking performance values.MVKQueueSubmission
,MVKMetalCompiler
,MVKShaderLibrary
, andMVKShaderLibraryCache
fromMVKBaseDeviceObject
to make use of these changes.Note to reviewers:
MVKDeviceTrackingMixin
andMVKDevice
inMVKDevice.h
, and toMVKCommandEncoder
inMVKCommandBuffer.h
.MVKDeviceTrackingMixin
instead of reaching intoMVKDevice
.