ISO C++11 warnings for constexpr modifier on mvkGetReportingLevelString()

KhronosGroup / MoltenVK

MoltenVK is a Vulkan Portability implementation. It layers a subset of the high-performance, industry-standard Vulkan graphics and compute API over Apple's Metal graphics framework, enabling Vulkan applications to run on macOS, iOS and tvOS.

Apache License 2.0

4.76k stars 419 forks source link

ISO C++11 warnings for constexpr modifier on mvkGetReportingLevelString() #2229

Closed SRSaunders closed 5 months ago

SRSaunders commented 5 months ago

Adding constexpr to mvkGetReportingLevelString() results in many clang warnings.

ISO C++11 does not allow conversion from string literal to 'char *'

I am using Ventura 13.6.6 with Xcode 15.2

(adding this here in case you did not see comment on closed PR #2224)

SRSaunders commented 5 months ago

I can see that you fixed this in d2677a69c0f3f9b9c7f2f99d53fa048bd523a4d6

Thanks, closing

billhollings commented 5 months ago

Yeah. Sorry That was my bad. That's what I get for using GitHub UI to change code functionality!

I should have just pulled your code in and tested locally to see if it warranted any mods.

Sorry for introducing the confusion. 🤦🏻‍♂️

And thanks for aiming to fix it!

SRSaunders commented 5 months ago

No worries, thanks for fixing.