Apply SPIRV-Cross workarounds for Metal bugs

KhronosGroup / MoltenVK

MoltenVK is a Vulkan Portability implementation. It layers a subset of the high-performance, industry-standard Vulkan graphics and compute API over Apple's Metal graphics framework, enabling Vulkan applications to run on macOS, iOS and tvOS.

Apache License 2.0

4.76k stars 419 forks source link

Apply SPIRV-Cross workarounds for Metal bugs #2248

Closed aitor-lunarg closed 3 months ago

aitor-lunarg commented 3 months ago

2 workarounds introduced:

Fragments with side effects will now execute following Vulkan
Depth/Stencil write postponed to post fragment execution when input attachment and depth/stencil attachment reference the same resource

Fixes #2232 Fixes #2233

aitor-lunarg commented 3 months ago

Looks like the corresponding SPIRV-Cross patch is already rolled into MoltenVK? Is that correct?

Yes, it was already included, that's why there's no SPIRV-Cross update needed

aitor-lunarg commented 3 months ago

Sorry for the delay on the update. I believe all comments should have been addressed. I will provide a follow up PR to handle the dynamic rendering case, mainly because it'll require bigger changes, and wanted to keep this PR small. If there's something I missed, do let me know!