KhronosGroup / MoltenVK

MoltenVK is a Vulkan Portability implementation. It layers a subset of the high-performance, industry-standard Vulkan graphics and compute API over Apple's Metal graphics framework, enabling Vulkan applications to run on macOS, iOS and tvOS.
Apache License 2.0
4.63k stars 402 forks source link

[ios18 support] add new case for Metal Version 3.2 that is on ios 18 -- reroutes MoltenMK to use version 3.1 #2255

Open Daij-Djan opened 2 weeks ago

Daij-Djan commented 2 weeks ago

This adds a new preprocessor macro for xcode16 / ios18 sdk and reroutes the version to 3.1 (additions to MVKDevice are iline with as what we did for other xcode versions in the past)

CLAassistant commented 2 weeks ago

CLA assistant check
All committers have signed the CLA.

Daij-Djan commented 1 week ago

I didnt wanna make any logic changes so I just made it 3.1 -- I didnt test runtime behaviour of moltenVK when I did the change.

billhollings commented 6 days ago

Change it to MTLLanguageVersion3_2 and test whether you can build using Xcode 15, to make sure it doesn't cause a regression break. If that is successful, we should be good.

If you have Xcode 16 up and running, test a build under that as well. If not, it should be good enough to go ahead with MTLLanguageVersion3_2 anyway.