Apparent bugs in execute_matmul

KhronosGroup / NNEF-Tools

The NNEF Tools repository contains tools to generate and consume NNEF documents

https://www.khronos.org/nnef

222 stars 57 forks source link

Apparent bugs in execute_matmul #115

Closed lxgo closed 4 years ago

lxgo commented 4 years ago

Hello

The following lines look like bugs to me:

In file master/parser/cpp/include/nnef/runtime/execution.h:

Line 478: have

auto& C = op.inputs.get("C");

should be

auto& C = op.outputs.get("C");

Line 481: have

bool trB = op.attribs.get("transposeA").logical();

should be

bool trB = op.attribs.get("transposeB").logical();

Kind regards

gyenesvi commented 4 years ago

You are right, thanks for catching these, I have corrected it. (I believe it has not been caught before because matmul was tested as part of linear op)