KhronosGroup / NNEF-Tools

The NNEF Tools repository contains tools to generate and consume NNEF documents
https://www.khronos.org/nnef
222 stars 57 forks source link

Apparent minor bugs in format specifications in flat_parser #117

Closed lxgo closed 4 years ago

lxgo commented 4 years ago

Hello

The following lines look like bugs to me.

In file parser/cpp/include/nnef/flat/flat_parser.h:

Line 232: have (%s), should be (%d):

throw Error(position, "left-hand-side item count must match result count of operation (%s)",
                (int)proto.resultCount());

Line 331: Trailing (%u,%u) doesn't correspond to any argument and should be removed:

throw Error(position, "duplicate arguments: parameter '%s' already assigned (%u,%u)",
                param->name().c_str());

Regards

gyenesvi commented 4 years ago

Right, thanks, corrected as well.