search

KhronosGroup / OpenCL-CLHPP

Khronos OpenCL-CLHPP
Apache License 2.0
369 stars 129 forks source link

Rename enqueueSignalSemaphore to enqueueSignalSemaphores for consistency #213

Closed kamilwiatrowskimobica closed 1 year ago

kamilwiatrowskimobica commented 1 year ago

Rename CommandQueue::enqueueSignalSemaphore to CommandQueue::enqueueSignalSemaphores to keep consistency with the underlying C API function.

There is CommandQueue::enqueueWaitSemaphores() as wrapper for clEnqueueWaitSemaphoresKHR so I assume it should be CommandQueue::enqueueSignalSemaphores() for clEnqueueSignalSemaphoresKHR.

It seems to be a recent addition so I hope it is not considered as a break of backwards compatibility.

CLAassistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.

bashbaug commented 1 year ago

I'm going to go ahead and merge this. If there are any CI failures (there shouldn't be) we can address them after the fact.