search

KhronosGroup / OpenCL-CLHPP

Khronos OpenCL-CLHPP
Apache License 2.0
369 stars 129 forks source link

UT for getObjectInfo #234

Closed piotr-wozniak-mobica closed 1 year ago

CLAassistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.

piotr-wozniak-mobica commented 1 year ago

Hi, this isn't building for me, on Windows or Linux:

10>------ Build started: Project: test_openclhpp_300_CL_HPP_USE_IL_KHR, Configuration: Debug x64 ------
10>test_openclhpp.cpp
10>D:\git\OpenCL-CLHPP\tests\test_openclhpp.cpp(4262,26): error C2601: 'testgetObjectInfo': local function definitions are illegal
10>D:\git\OpenCL-CLHPP\tests\test_openclhpp.cpp(4257): message : this line contains a '{' which has not yet been matched
10>D:\git\OpenCL-CLHPP\tests\test_openclhpp.cpp(11): fatal error C1075: '{': no matching token found
10>Done building project "test_openclhpp_300_CL_HPP_USE_IL_KHR.vcxproj" -- FAILED.

Can you please also say a little more what this case is intending to test? Thanks!

I just created a test for function that was not tested but after mocking functions I realise that there is only one scenario to cover in UT and its just passing value from another mocked function. Additionally this PR introduce mocks for functions from cl_gl.h file that can be useful for other UTs.

bashbaug commented 1 year ago

Merging as discussed in the September 12th teleconference.