KhronosGroup / OpenCL-CLHPP

Khronos OpenCL-CLHPP
Apache License 2.0
375 stars 129 forks source link

fix preprocessor guards for getContextPlatformVersion #245

Closed bashbaug closed 11 months ago

bashbaug commented 1 year ago

fixes #108

This change corrects the preprocessor guards around detail functions to get the OpenCL version from a platform, device, or context.

Debatably the preprocessor guards around these functions should be removed completely, but at least this way things won't be broken while we figure out if this is the right thing to do or not.

bashbaug commented 1 year ago

Need to file an issue (or add a test) to ensure these types of failures are caught in the future.

bashbaug commented 1 year ago

I've added a test to ensure these issues will be caught in the future - see https://github.com/KhronosGroup/OpenCL-CLHPP/pull/252. These tests fail currenlty, but will pass once this PR is merged.

bashbaug commented 11 months ago

Merging as discussed in the December 5th teleconference.