search

KhronosGroup / OpenCL-CLHPP

Khronos OpenCL-CLHPP
Apache License 2.0
375 stars 130 forks source link

remove removed external memory and semaphore extensions #295

Closed bashbaug closed 4 months ago

bashbaug commented 4 months ago

We're removing the cl_khr_external_memory_dx and cl_khr_external_semaphore_dx_fence extensions due to lack of implementations and test coverage,so the handle types added by these extensions should also be removed from the C++ headers.

See: https://github.com/KhronosGroup/OpenCL-Docs/pull/1160

If we decide to keep the handle types for these extensions in the C++ headers for whatever reason, we should still keep the first commit, which adds the necessary include guards around each of the external memory handle types.

Fixes: https://github.com/KhronosGroup/OpenCL-Headers/issues/255

bashbaug commented 4 months ago

Looks like this is still failing, even after merging the latest CI/CD changes from the main branch. The main branch is failing too, though.

I'm going to go ahead and merge this because it is causing build failures with the latest headers. We still need to fix the CI issues, though...