search

KhronosGroup / OpenCL-CLHPP

Khronos OpenCL-CLHPP
Apache License 2.0
369 stars 129 forks source link

Update clUpdateMutableCommandsKHR binding #298

Closed EwanC closed 1 week ago

EwanC commented 1 month ago

In OpenCL-Docs PR https://github.com/KhronosGroup/OpenCL-Docs/pull/1045 the API for cl_khr_command_buffer_mutable_dispatch API clUpdateMutableCommandsKHR changed in a breaking way.

When the headers update OpenCL-Headers PR https://github.com/KhronosGroup/OpenCL-Headers/pull/245 the bindings will break if they are not updated to reflect this change.

Bindings updated in this PR to pass to arrays of templated length to the C++ method. The underlying .data() pointers of these parameters can be passed through to the OpenCL API. I don't think any tests for this API currently exist in the repo to be updated.

CLAassistant commented 1 month ago

CLA assistant check
All committers have signed the CLA.

EwanC commented 1 week ago

These changes look good, but they'll break without the corrosponding header updates. Should we use the extension versioning mechanism to either a) only expose this function when the headers are sufficiently new, or b) select between both versions, for some time at least?

I forgot to reply when I made this change, but I updated to option b)