Fix updateMutableCommands template to use std::array::size() and const pointers

KhronosGroup / OpenCL-CLHPP

Khronos OpenCL-CLHPP

Apache License 2.0

375 stars 130 forks source link

Fix updateMutableCommands template to use std::array::size() and const pointers #306

Closed banan328 closed 3 weeks ago

banan328 commented 1 month ago

This pull request fixes this commit https://github.com/KhronosGroup/OpenCL-CLHPP/pull/298:

Replaced configs.length() with configs.size() to correctly retrieve the array size.
Changed configs to std::array<const void*, ArrayLength> for better const-correctness.
Passed config_types.data(), configs.data() directly to pfn_clUpdateMutableCommandsKHR.

bashbaug commented 1 month ago

Could you add a test for this function?

(It would have been good to do that previously, since it probably would have caught these bugs earlier.)

EwanC commented 1 month ago

Could you add a test for this function?

(It would have been good to do that previously, since it probably would have caught these bugs earlier.)

There is an open PR https://github.com/KhronosGroup/OpenCL-CLHPP/pull/276 with some testing, will probably be a bit stale and need updated but could prioritize getting that in as a follow-up.

EwanC commented 1 month ago

Could you add a test for this function? (It would have been good to do that previously, since it probably would have caught these bugs earlier.)

There is an open PR #276 with some testing, will probably be a bit stale and need updated but could prioritize getting that in as a follow-up.

I've created https://github.com/KhronosGroup/OpenCL-CLHPP/pull/308 which updates and combines the work. So would supersede this PR and #276 if we merged it

bashbaug commented 3 weeks ago

Fixed by #308 - closing.