Open bashbaug opened 2 years ago
A good initial step towards resolving this issue would be a test plan documenting what will be tested.
@bashbaug @Snektron in most cases such comparability is already performed, I went through spec and CTS. It looks like the problem is mostly related to querying command queues, I found multiple similar comments:
// We can not check if this is the right queue because this is an opaque
// object.
I am assuming this is no longer correct statement and we should compare queried command queues just like in cases of command_buffer_get_command_buffer_info.cpp. Below my comments for completed and missing cases:
clGetCommandBufferInfoKHR
with params: clGetCommandQueueInfo
with params: clGetContextInfo
with param: clGetDeviceInfo
with param: clGetGLContextInfoKHR
with params: clGetKernelInfo
with params: clGetMemObjectInfo
with params: clGetMutableCommandInfoKHR
with params: clGetProgramInfo
with params: clGetSamplerInfo
with param: clGetSemaphoreInfoKHR
with params: clGetEventInfo
with params: I will appreciate discussion over these concerns:
1) Is the above list complete, any thoughts on complementing that ? 2) Already covered cases are spreaded among CTS. I guess there is no way around than to follow that scheme with missing cases, right ?
See https://github.com/KhronosGroup/OpenCL-Docs/issues/797.
We should add basic testing for object comparability, to ensure that object handles compare equal when they are queried from child objects.