KhronosGroup / OpenCL-CTS

The OpenCL Conformance Tests
Apache License 2.0
185 stars 199 forks source link

add test for object comparability #1485

Open bashbaug opened 2 years ago

bashbaug commented 2 years ago

See https://github.com/KhronosGroup/OpenCL-Docs/issues/797.

We should add basic testing for object comparability, to ensure that object handles compare equal when they are queried from child objects.

bashbaug commented 2 months ago

A good initial step towards resolving this issue would be a test plan documenting what will be tested.

shajder commented 1 month ago

@bashbaug @Snektron in most cases such comparability is already performed, I went through spec and CTS. It looks like the problem is mostly related to querying command queues, I found multiple similar comments:

    // We can not check if this is the right queue because this is an opaque
    // object.

I am assuming this is no longer correct statement and we should compare queried command queues just like in cases of command_buffer_get_command_buffer_info.cpp. Below my comments for completed and missing cases:

  1. clGetCommandBufferInfoKHR with params:
  1. clGetCommandQueueInfo with params:
  1. clGetContextInfo with param:
  1. clGetDeviceInfo with param:
  1. clGetGLContextInfoKHR with params:
  1. clGetKernelInfo with params:
  1. clGetMemObjectInfo with params:
  1. clGetMutableCommandInfoKHR with params:
  1. clGetProgramInfo with params:
  1. clGetSamplerInfo with param:
  1. clGetSemaphoreInfoKHR with params:
  1. clGetEventInfo with params:

I will appreciate discussion over these concerns:

1) Is the above list complete, any thoughts on complementing that ? 2) Already covered cases are spreaded among CTS. I guess there is no way around than to follow that scheme with missing cases, right ?