Escape subnormal values - Githubissues

KhronosGroup / OpenCL-CTS

The OpenCL Conformance Tests

Apache License 2.0

178 stars 187 forks source link

Escape subnormal values #1953

Closed shiltian closed 1 month ago

shiltian commented 2 months ago

Currently we don't escape subnormal values when generating image data. In sampler read tests, we use != to check the two values even when it is floating-point data, which requires the two values are bitwise equal. However, a sampler might flush subnormal values, causing the test case to fail.

In this patch, when generating random image data, we escape subnormal values.

CLAassistant commented 2 months ago

All committers have signed the CLA.

b-sumner commented 2 months ago

Section 8.3.3 of the C spec specifically allows sampling to flush denorms, so this change seems to be long overdue.

lakshmih commented 1 month ago

Reviewing

bashbaug commented 1 month ago

A bit of spec archaeology, for the Khronos folks:

A fix similar to this one was proposed in Bugzilla 16324.
The spec changes were discussed in GitLab issues 30 and 113.

shiltian commented 1 month ago

I don't have privileges to merge the PR. Can someone do it for me? Thanks!

bashbaug commented 1 month ago

It'd be nice to get one more approval before merging - @silverclaw or @lakshmih maybe?

If not, we'll aim to merge in our next teleconference, on Tuesday (June 4th).

bashbaug commented 1 month ago

Thanks! Merging.