Added new cl_khr_semaphore tests to verify clCreateSemaphoreWithPropertiesKHR negative results

KhronosGroup / OpenCL-CTS

The OpenCL Conformance Tests

Apache License 2.0

184 stars 196 forks source link

Added new cl_khr_semaphore tests to verify clCreateSemaphoreWithPropertiesKHR negative results #1962

Closed shajder closed 1 month ago

shajder commented 5 months ago

According to work plan from #1691, new clSemaphoreWrapper introduced to avoid duplication of code

shajder commented 3 months ago

CL_INVALID_SEMAPHORE_KHR is an error code. Define an invalid property local to the test, this is not correct usage of the macro

@joshqti thanks, do you have other values on your mind ? Please keep in mind it supposed to be incorrect usage because this is negative test! CL_INVALID_SEMAPHORE_KHR is neither valid name nor property in this case.

kpet commented 3 months ago

2024/07/02 teleconference: @shajder Could you rebase/resolve conflicts please?

nikhiljnv commented 2 months ago

Summarizing discussion from memory subgroup call of July 9th 2024.

Per Joshua's comment, using CL_INVALID_SEMAPHORE error code as a property value is confusing. Ben suggested two options

Clarify in a comment that CL_INVALID_SEMAPHORE which is an error code is actually an invalid value that can be passed to test error condition.
Alternatively, pass a different value instead of CL_INVALID_SEMAPHORE to avoid the confusion.

shajder commented 2 months ago

Per Joshua's comment, using CL_INVALID_SEMAPHORE error code as a property value is confusing. Ben suggested two options

corrected according to mentioned suggestion

nikhiljnv commented 1 month ago

Merging as discussed in memory subgroup call on August 6th 2024.