search

KhronosGroup / OpenCL-CTS

The OpenCL Conformance Tests
Apache License 2.0
184 stars 196 forks source link

Add fp16 testing to conversions and bruteforce #1975

Closed svenvh closed 3 months ago

svenvh commented 4 months ago

Merge the fp16-staging branch into main, adding fp16 (half) testing to the conversions and math bruteforce tests.

svenvh commented 4 months ago

As we don't seem to have any remaining issues or concerns with the new fp16 conversions and math bruteforce tests, now would be a good time to merge the staging branch into the main branch. Any further issues with the new tests we can address on main as part of normal CTS maintenance.

Most of this work has already been reviewed in other pull requests; I've structured this PR into a merge commit that merges the already-reviewed fp16-staging branch, followed by some small "fixup" commits.

bashbaug commented 3 months ago

Merging as discussed in the June 18th teleconference.

Need to check if any .csv files need to be updated to account for these new tests.

svenvh commented 3 months ago

Need to check if any .csv files need to be updated to account for these new tests.

The opencl_conformance_tests_*.csv files always list the entire bruteforce and conversions binaries without specifying subtests, so I believe that there's nothing to do for those files.

test_conformance/spir/khr.csv does list individual tests, but it would probably need corresponding SPIR files first. (That's the old SPIR, not SPIR-V.)