The skipTestingRelaxed check suffers the following problems:
The use of skipTestingRelaxed in the if seems reversed: when skipping correctness testing using the -l command line option, this variable causes correctness testing to be run for relaxed-mode tan regardless.
Accuracy testing should only be skipped for derived tan implementations. Non-derived tan implementations must still be tested for accuracy, so the condition for setting the skipTestingRelaxed variable is incomplete.
It is unclear why only tan is conditionalized here. There are other functions such as tanpi for which one would expect identical behaviour.
The actual skipping of accuracy checks for derived implementations happens in Test(), so just remove skipTestingRelaxed as it does not seem to add any value.
The
skipTestingRelaxedcheck suffers the following problems:The use of
skipTestingRelaxedin theifseems reversed: when skipping correctness testing using the-lcommand line option, this variable causes correctness testing to be run for relaxed-modetanregardless.Accuracy testing should only be skipped for derived
tanimplementations. Non-derivedtanimplementations must still be tested for accuracy, so the condition for setting theskipTestingRelaxedvariable is incomplete.It is unclear why only
tanis conditionalized here. There are other functions such astanpifor which one would expect identical behaviour.The actual skipping of accuracy checks for derived implementations happens in
Test(), so just removeskipTestingRelaxedas it does not seem to add any value.