KhronosGroup / OpenCL-CTS

The OpenCL Conformance Tests
Apache License 2.0
184 stars 196 forks source link

Fix bug in copy image mipmap comparisons #2032

Open joshqti opened 2 months ago

joshqti commented 2 months ago

The destination image for mipmap copies is incorrect, use the width of the mip-level instead of mip-level 0. The check if (where < dstImageInfo->width) is not correct, width is the size of level 0, but it should be the width of the destination mip level.

Deletes redundant scanline comparison, which is confusing and uneccesary. compare_scanline and memcmp do the same thing, except compare_scanline correctly take image format into account, whereas memcmp finds all differences.